-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: blurry svgs in safari #2507
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ This PR introduced no changes to the javascript bundle π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to address the issue but have some clarification questions related to the package update and the bundle size!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! π₯ Awesome work!
Mind removing the note about the bundle size in your PR description before merging?
π Relevant links
ποΈ What
This PR updates the
try-hcp-callout
side image to use the svg inline vs as the background image. This is due to a bug in safari where the svgs look blurry. This PR fixes that issue and also another issue where svg ids are being duplicated (more context here)πΈ Design Screenshots
Before
After
π§ͺ Testing