-
Notifications
You must be signed in to change notification settings - Fork 27
feat: zendesk search integration #2722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
d1dccd9
WIP: zendesk integration
LeahMarieBush 90961a5
change name to knowledgebase
LeahMarieBush 57b3986
Merge branch 'main' into leah/feat/zendesk
LeahMarieBush 62e017c
update tab name and icon
LeahMarieBush 02ed54c
add zendesk hits to global
LeahMarieBush f092e16
use algolia snippet compoenent
LeahMarieBush 0d98ebf
update global hits
LeahMarieBush d20da69
use dev zendesk site for dev algolia index
LeahMarieBush f49e7f7
add external link indicator
LeahMarieBush cd805a1
Merge branch 'main' into leah/feat/zendesk
LeahMarieBush f2ec232
change to using prod zendesk url
LeahMarieBush d2f038f
revert
LeahMarieBush f70dd41
Merge branch 'main' into leah/feat/zendesk
LeahMarieBush 005c143
make all tab only have 20 results
LeahMarieBush bf4b645
clean up types
LeahMarieBush b4753e4
more words in snippet
LeahMarieBush 01734c1
add filters
LeahMarieBush 9ca9261
Merge branch 'main' into leah/feat/zendesk
LeahMarieBush 19a669a
change index id to use enum
LeahMarieBush 0816331
Merge branch 'main' into leah/feat/zendesk
LeahMarieBush 28ee5d9
Merge branch 'main' into leah/feat/zendesk
LeahMarieBush 7fe62d3
update attributesToHighlight length to avoid hitting the limit
LeahMarieBush caf25a1
only add knowledgebase hits to global once
LeahMarieBush File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about just using
Object.values
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea but since we are not mapping over every value (SearchContentTypes.KNOWLEDGEBASE is not here), I'm going to keep this the same for now. When we switch over to using the omni index after launch I'll update this to use Object.values tho!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof - you're absolutely right! I thought I'd checked for this, but my eyes glanced over the missing
SearchContentTypes.KNOWLEDGEBASE
. Good catch!