Add support for Event Hub SAS Helper #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tombuildsstuff
approved these changes
May 10, 2023
There was a problem hiding this comment.
LGTM - apologies for the delayed review here @neil-yechenwei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To figure out hashicorp/terraform-provider-azurerm#7160, it has to submit this PR to add Event Hub SAS Helper first. After this is merged, it has to submit another PR to add Event Hub SAS data source in terraform azurerm provider.
--- PASS: TestComputeEventHubSASConnectionUrl (0.00s)
--- PASS: TestComputeEventHubSASConnectionString (0.00s)
--- PASS: TestComputeEventHubSASToken (0.00s)
--- PASS: TestParseEventHubConnectionString (0.00s)
Reference:
https://docs.microsoft.com/en-us/rest/api/eventhub/generate-sas-token#powershell
https://docs.microsoft.com/en-us/azure/event-hubs/authenticate-shared-access-signature#generate-a-shared-access-signature-token