Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refact DeleteItems(...) to batch deletes #57

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

jimlambrt
Copy link
Collaborator

A follow up to #55, this PR properly implement batch deletes.

Copy link
Member

@tmessi tmessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to fix one thing in a comment.

delete.go Outdated Show resolved Hide resolved
Only call WithBeforeWrite(...) and
WithAfterWrite(...) once for all items vs for
every individual item.
you can't call reflect.Value.IsNil on an array
@jimlambrt jimlambrt force-pushed the jimlambrt-delete-items branch from 2d5c356 to 0cfcf4e Compare July 29, 2024 13:08
@jimlambrt jimlambrt merged commit 0cfcf4e into main Jul 29, 2024
8 checks passed
@jimlambrt jimlambrt deleted the jimlambrt-delete-items branch July 29, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants