Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Equinix Metal provider #177

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

displague
Copy link

Part of #176

"ignore": "test",
"package": [
{
"checksumSHA1": "kItpnJu5G9MVC56waIyHLoQZt/s=",
Copy link
Author

@displague displague Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to generate checksumSHA1. Any pointers @pearkes?

Copy link
Author

@displague displague Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to automate the creation of these deep vendors/ directories, or just the vendor.json file?

@@ -5,9 +5,9 @@
{
"checksumSHA1": "kItpnJu5G9MVC56waIyHLoQZt/s=",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packet/vendor/vendor.json checksumSHA1 will also need to be updated.

}
],
"rootPath": "github.com/hashicorp/go-discover/provider/packet"
"rootPath": "github.com/hashicorp/go-discover/provider/equinixmetal"
Copy link
Author

@displague displague Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be packet.

Suggested change
"rootPath": "github.com/hashicorp/go-discover/provider/equinixmetal"
"rootPath": "github.com/hashicorp/go-discover/provider/packet"

@@ -0,0 +1,46 @@
provider "metal" {
version = "~> 2.8.1"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "~> 2.8.1"
version = "~> 2.1"

@@ -0,0 +1,10 @@

terraform {
required_version = ">= 0.13"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this version of TF possible with the current testing?

@displague displague marked this pull request as draft June 18, 2021 22:52
@displague displague changed the title Add Equinix metal provider Add Equinix Metal provider Jun 18, 2021
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
@displague displague marked this pull request as ready for review September 1, 2022 20:58
@@ -10,7 +10,7 @@ locals:
executors:
go:
docker:
- image: docker.mirror.hashicorp.services/circleci/golang:1.13.15
- image: docker.mirror.hashicorp.services/circleci/golang:1.16.5
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packngo requires go v1.15+

I can remove this line if #200 (or similar) is merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants