[fix] Windows junction handling (#557)

* Windows checks

* Try old Go

* Try again

* Add debug

* Windows

* New winsymlink

* Debug copyDir

* Windows fallback

* Try file getter

* Try file getter

* Add windows debuggery

* Handle windows differently

* Windows fixes?

* Remove debuggery

* Refactor to return early

* Closing in

* Tweak fixes

* windows not working right

* Fix logic around junctions

* It was never working

* More robust junction check

* Robuster junction point check

* Cleaner

* Fallback more generously

* Debug more

* Be more like EvalSymlinks

* Tighten up code

* Further cleaning

* Reasonable .gitignore

* Fix resolving junction points on Windows

* Add windows/unix unit tests

* Fix linter error

* Windows test failures

* Another try at windows test failures

* Probably not fix windows test failures

Author: YakDriver

.gitignore

@@ -1 +1,75 @@
+# Binaries for programs and plugins
+*.exe
+*.exe~
+*.dll
+*.so
+*.dylib
+
+# Test binary, built with `go test -c`
+*.test
+
+# Output of the go coverage tool, specifically when used with LiteIDE
+*.out
+
+# Dependency directories (remove the comment below to include it)
+# vendor/
+
+# Go workspace file
+go.work
+
+# Build artifacts
+/bin/
+/build/
+/dist/
+
+# Project-specific binaries
 cmd/go-getter/go-getter
+go-getter
+
+# IDE files
+.vscode/
+.idea/
+*.swp
+*.swo
+*~
+
+# OS generated files
+.DS_Store
+.DS_Store?
+._*
+.Spotlight-V100
+.Trashes
+ehthumbs.db
+Thumbs.db
+
+# Test coverage
+*.coverprofile
+coverage.html
+coverage.out
+
+# Temporary files
+*.tmp
+*.temp
+
+# Log files
+*.log
+
+# Environment files
+.env
+.env.local
+.env.*.local
+
+# Profiling data
+*.prof
+*.pprof
+
+# Air live reload tool
+tmp/
+
+# Archives
+*.tar
+*.tar.gz
+*.zip
+
+# Local test fixtures (if any)
+/test-fixtures-local/

copy_dir.go

@@ -23,8 +23,7 @@ func mode(mode, umask os.FileMode) os.FileMode {
 func copyDir(ctx context.Context, dst string, src string, ignoreDot bool, disableSymlinks bool, umask os.FileMode) error {
 	// We can safely evaluate the symlinks here, even if disabled, because they
 	// will be checked before actual use in walkFn and copyFile
-	var err error
-	resolved, err := filepath.EvalSymlinks(src)
+	resolved, err := resolveSymlinks(src)
 	if err != nil {
 		return err
 	}

get_file_test.go

@@ -29,12 +29,26 @@ func TestFileGetter(t *testing.T) {
 		t.Fatalf("err: %s", err)
 	}
 
-	// On Unix, verify it's a symlink; on Windows, just verify it works
-	if runtime.GOOS != "windows" {
-		fi, err := os.Lstat(dst)
-		if err != nil {
-			t.Fatalf("err: %s", err)
+	// Verify it's a symlink on Unix or junction point on Windows
+	fi, err := os.Lstat(dst)
+	if err != nil {
+		t.Fatalf("err: %s", err)
+	}
+
+	if runtime.GOOS == "windows" {
+		isJunction, junctionErr := isWindowsJunctionPoint(dst)
+		if junctionErr != nil {
+			t.Fatalf("failed to check if destination is a junction point: %s", junctionErr)
+		}
+		if !isJunction {
+			t.Fatal("destination is not a junction point")
+		}
+		// Additional verification: should be accessible as a directory
+		if dirInfo, err := os.Stat(dst); err != nil || !dirInfo.IsDir() {
+			t.Fatal("destination junction point is not accessible as a directory")
 		}
+	} else {
+		// On Unix, verify it's a traditional symlink
 		if fi.Mode()&os.ModeSymlink == 0 {
 			t.Fatal("destination is not a symlink")
 		}

get_file_windows.go

@@ -1,6 +1,7 @@
 // Copyright (c) HashiCorp, Inc.
 // SPDX-License-Identifier: MPL-2.0
 
+//go:build windows
 // +build windows
 
 package getter

get_http.go

@@ -533,8 +533,7 @@ func (g *HttpGetter) getSubdir(ctx context.Context, dst, source, subDir string,
 
 	// Make sure the subdir path actually exists
 	if _, err := os.Stat(sourcePath); err != nil {
-		return fmt.Errorf(
-			"Error downloading %s: %s", source, err)
+		return fmt.Errorf("downloading %s: %s", source, err)
 	}
 
 	// Copy the subdirectory into our actual destination.

get_http_test.go

@@ -15,7 +15,6 @@ import (
 	"net/url"
 	"os"
 	"path/filepath"
-	"runtime"
 	"strconv"
 	"strings"
 	"testing"
@@ -142,11 +141,6 @@ func TestHttpGetter_meta(t *testing.T) {
 }
 
 func TestHttpGetter_metaSubdir(t *testing.T) {
-	// Skip this test on Windows due to file:// URL subdirectory resolution issues
-	if runtime.GOOS == "windows" {
-		t.Skip("Skipping meta subdir test on Windows due to file:// URL path resolution issues")
-	}
-
 	ln := testHttpServer(t)
 	defer func() { _ = ln.Close() }()
 
@@ -171,11 +165,6 @@ func TestHttpGetter_metaSubdir(t *testing.T) {
 }
 
 func TestHttpGetter_metaSubdirGlob(t *testing.T) {
-	// Skip this test on Windows due to file:// URL subdirectory resolution issues
-	if runtime.GOOS == "windows" {
-		t.Skip("Skipping meta subdir glob test on Windows due to file:// URL path resolution issues")
-	}
-
 	ln := testHttpServer(t)
 	defer func() { _ = ln.Close() }()
 

go.mod

@@ -17,6 +17,7 @@ require (
 	github.com/mitchellh/go-homedir v1.1.0
 	github.com/ulikunitz/xz v0.5.15
 	golang.org/x/oauth2 v0.27.0
+	golang.org/x/sys v0.35.0
 	google.golang.org/api v0.114.0
 )
 
@@ -46,7 +47,6 @@ require (
 	github.com/mattn/go-runewidth v0.0.4 // indirect
 	go.opencensus.io v0.24.0 // indirect
 	golang.org/x/net v0.43.0 // indirect
-	golang.org/x/sys v0.35.0 // indirect
 	golang.org/x/text v0.28.0 // indirect
 	golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
 	google.golang.org/appengine v1.6.7 // indirect

symlinks_unix.go

@@ -0,0 +1,25 @@
+//go:build !windows
+// +build !windows
+
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+
+package getter
+
+import (
+	"path/filepath"
+)
+
+// resolveSymlinks resolves symlinks
+func resolveSymlinks(src string) (string, error) {
+	resolved, err := filepath.EvalSymlinks(src)
+	if err != nil {
+		return "", err
+	}
+	return resolved, nil
+}
+
+// isWindowsJunctionPoint is a no-op on non-Windows platforms
+func isWindowsJunctionPoint(_ string) (bool, error) {
+	return false, nil
+}