Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to not download local files and simply reference them 'inplace' given an option #232

Merged
merged 10 commits into from
Feb 4, 2020

Conversation

azr
Copy link
Contributor

@azr azr commented Jan 28, 2020

This pr is based upon #230 and #231, merging it will close them; but I split them in order to allow to review the changes in smaller contextualised chunks. ( which I recommend )

This PR adds the Inplace bool field to a Request allowing to use local files 'inplace' and just setting the Operation.Dst to the source file.

This will allow Packer to not do any operation and to use big local files 'inplace'.

This PR reopens #178

@azr azr requested a review from notnoop January 28, 2020 18:08
@azr
Copy link
Contributor Author

azr commented Jan 28, 2020

Hello @notnoop I'm sorry I reopened #178 (and source branches/PR) in order to merge them on v2, and to rebase them on the latest master, this will save us from some headaches in the future.

I picked v2 because that's what the hcl repo does: https://pkg.go.dev/github.com/hashicorp/hcl/v2?tab=doc

@azr azr mentioned this pull request Jan 30, 2020
Copy link
Member

@jbardin jbardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the plan of putting the options into the "Request". Overall I think this will be a better approach, just left a couple comments inline.

get_file_symlink_windows.go Outdated Show resolved Hide resolved
client_option.go Outdated Show resolved Hide resolved
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - these changes are awesome. Thanks for the redisgn. I made a couple of comments in previous PRs that carry over here, the code specific to this PR lgtm.

@azr azr mentioned this pull request Feb 4, 2020
@azr azr changed the title File inplace Allow to not download local files and simply reference them 'inplace' given an option Feb 4, 2020
@azr
Copy link
Contributor Author

azr commented Feb 4, 2020

Super awesome; many thanks for reviewing @jbardin and @notnoop; I'll merge this and leave the v2 branch untagged for a while in case some other breaking change needs to happen or something is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants