-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to not download local files and simply reference them 'inplace' given an option #232
Conversation
Hello @notnoop I'm sorry I reopened #178 (and source branches/PR) in order to merge them on v2, and to rebase them on the latest master, this will save us from some headaches in the future. I picked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the plan of putting the options into the "Request". Overall I think this will be a better approach, just left a couple comments inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - these changes are awesome. Thanks for the redisgn. I made a couple of comments in previous PRs that carry over here, the code specific to this PR lgtm.
This pr is based upon #230 and #231, merging it will close them; but I split them in order to allow to review the changes in smaller contextualised chunks. ( which I recommend )
This PR adds the Inplace bool field to a Request allowing to use local files 'inplace' and just setting the Operation.Dst to the source file.
This will allow Packer to not do any operation and to use big local files 'inplace'.
This PR reopens #178