Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(detector): provide a detector for repository hosted on GitLab.com #259

Merged
merged 1 commit into from
Sep 16, 2020
Merged

feat(detector): provide a detector for repository hosted on GitLab.com #259

merged 1 commit into from
Sep 16, 2020

Conversation

davinkevin
Copy link
Contributor

This is a really simple implementation based on the GitHub detector for GitLab URL. It only supports URL with format gitlab.com/username/repo

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 7, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

azr
azr approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sysadmiral
sysadmiral reviewed Sep 15, 2020
View reviewed changes
detect_gitlab.go Outdated Show resolved Hide resolved
azr
azr reviewed Sep 15, 2020
View reviewed changes
detect_gitlab.go Outdated Show resolved Hide resolved
@davinkevin davinkevin force-pushed the feat-detector-support-gitlab-com-urls branch from 1fba7b1 to 4d87346 Compare September 15, 2020 17:04
@azr azr merged commit 437601e into hashicorp:master Sep 16, 2020
@azr
Copy link
Contributor

azr commented Sep 16, 2020

Thanks !

azr pushed a commit that referenced this pull request Sep 30, 2020
@davinkevin @azr
feat(detector): provide a detector for repository hosted on GitLab.com (
7775aaf 
#259)
@azr azr mentioned this pull request Sep 30, 2020
Merged
azr added a commit that referenced this pull request Sep 30, 2020
@azr @davinkevin
feat(detector): provide a detector for repository hosted on GitLab.com (
d436e03 
#259) (#281)

* feat(detector): provide a detector for repository hosted on GitLab.com (#259)

* remove hg test after #276

Co-authored-by: Davin Kevin <davin.kevin@gmail.com>
@nywilken nywilken mentioned this pull request Jun 6, 2022
Merged
@nywilken nywilken mentioned this pull request Nov 30, 2022
Merged
This was referenced Mar 16, 2023
Merged
Closed
@nywilken nywilken mentioned this pull request May 20, 2024
Merged
@nywilken nywilken mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sysadmiral sysadmiral sysadmiral left review comments

@azr azr azr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davinkevin @hashicorp-cla @azr @sysadmiral