Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor copy=true in directory mode for local file copies #327

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
3244205
Honor copy=true in directory mode in local file copies
ebudan Jun 24, 2021
ef9a8a0
fixed destination setup when copying dir
ebudan Jun 29, 2021
67b1548
use own module path
ebudan Jun 29, 2021
04ae861
Adds support for vhost-style s3 buckets
danieleva Oct 15, 2020
550028f
Remove go tests from goreleaser
mdeggies Nov 12, 2020
a6b1e04
Set path to main func in goreleaser
mdeggies Nov 12, 2020
d799a3b
add zstd support
yaroot Nov 5, 2020
f5eead5
Switch to docker mirror (#291)
mdeggies Nov 23, 2020
d9e18df
enable GitHub code scanning workflow (#295)
finnigja Dec 23, 2020
5fd09cd
Set GOPRIVATE env var (#301)
mdeggies Jan 7, 2021
ca56ba7
Add support for gcs object generations
ScottSuarez Feb 25, 2021
0f4750b
remove debugging code
ScottSuarez Feb 25, 2021
991a3e8
add testcase and make generation check fail if invalid generation is …
ScottSuarez Feb 26, 2021
49afe95
clarify comments
ScottSuarez Feb 26, 2021
58959e1
fixed debugging comment... okay this should be good to go
ScottSuarez Feb 26, 2021
87031b1
Bump go-cleanhttp to 0.5.2
radeksimko Mar 31, 2021
4625fad
add test
radeksimko Mar 31, 2021
a6108ff
test for race conditions in CI
radeksimko Mar 31, 2021
3400df5
Avoid reusing the same http.Request
radeksimko Mar 31, 2021
5418658
TestGCSGetter_GetGenerationFile: use our test bucket (#312)
azr Apr 1, 2021
ecafb46
Add support to detect 5 parts s3 virtual hosted-style requests
ericdong66 Mar 29, 2021
eb4b608
Add insecure flag for http getter
chrisgilmerproj May 4, 2021
0b3a49a
http: Initialize http.Request with ctx so cancelation interrupts the …
zeisss May 12, 2021
860d133
Correct typo in error message (#322)
sfdc-jd May 31, 2021
1e55ccb
ci: bump MSV of go to 1.15.13 (#325)
tgross Jun 17, 2021
e7bb69b
Honor copy=true in directory mode in local file copies
ebudan Jun 24, 2021
16c3490
fixed destination setup when copying dir
ebudan Jun 29, 2021
7f0872c
Merge branch 'main' of ssh://github.com/ebudan/go-getter
ebudan Jul 22, 2021
56be771
Added test; reverted parent dir creation; reverted module path
ebudan Jul 22, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions get_file_unix.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,15 @@ func (g *FileGetter) Get(dst string, u *url.URL) error {
}

// Create all the parent directories
if err := os.MkdirAll(filepath.Dir(dst), g.client.mode(0755)); err != nil {
if err := os.MkdirAll(dst, g.client.mode(0755)); err != nil {
ebudan marked this conversation as resolved.
Show resolved Hide resolved
return err
}

return os.Symlink(path, dst)
if !g.Copy {
return os.Symlink(path, dst)
}

return copyDir(g.Context(), dst, path, false, g.client.umask())
}

func (g *FileGetter) GetFile(dst string, u *url.URL) error {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/hashicorp/go-getter
module github.com/ebudan/go-getter
ebudan marked this conversation as resolved.
Show resolved Hide resolved

require (
cloud.google.com/go v0.45.1
Expand Down