Update default Getters with known defaults #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* By default XTerrformGet header support should be disable; clients needing supporting this header should overwrite the default getters with a custom HttpGetter * Add default timeouts for HTTP Read Requests; including HEAD requests
picatz
reviewed
May 20, 2022
| Netrc: true, | ||
| Netrc: true, | ||
| XTerraformGetDisabled: true, | ||
| HeadFirstTimeout: 10 * time.Second, |
There was a problem hiding this comment.
🤔 Maybe we should go with DoNotCheckHeadFirst, to avoid the initial HEAD request altogether.
Suggested change
| HeadFirstTimeout: 10 * time.Second, | |
| DoNotCheckHeadFirst: true, |
What do you think?
There was a problem hiding this comment.
Packer uses the default Getter settings with a few additional Getters. I updated them to match what we plan to use in Packer. That said, I think Packer could take advantage of the Range header. So I opted for the HeadFirstTimeout over the disabling it entirely. Does that sound reasonable to you?
There was a problem hiding this comment.
Given the need of the changes. I went ahead and merged as is. If after working through Packer further we find we can disable entirely. We can revisit. But sticking with this default for now.
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default XTerrformGet header support should be disable; clients
needing supporting this header should overwrite the default getters
with a custom HttpGetter
Add default timeouts for HTTP Read Requests; including HEAD requests