Port Decompression bomb security changes from v1 #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port changes from v1 #292
nywilken
force-pushed
the
decompression-bomb-port
branch
2 times, most recently
from
f264204
to
6367bae
Compare
picatz
requested changes
Feb 9, 2023
nywilken
force-pushed
the
decompression-bomb-port
branch
from
4add561
to
1321450
Compare
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #407 (reserved as
CVE-2023-0475), by introducing "(de)compression" bomb mitigation options to the various decompressors provided by this package. Specifically,FileSizeLimitandFilesLimit.FileSizeLimitlimits the size of a decompressed file, or limits the total size of all decompressed files if dealing with an archive.FilesLimitlimits the number of files that are allowed to be decompressed from an archive.These changes were ported from v1.
In addition to the security changes support for ZTSD as a supported decompressor was also ported.