Remove bomb.zip test file to stop anti-virus noise
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was useful to verify the zip bomb protections worked properly against a real "zip bomb", but is not required to verify out mitigations works in our tests. Including a real zip bomb lead to confusion and reports of anti-virus causing issues for users.
|
cc @nywilken we probably need to get this same change landed in v2 sometime in the near future. |
Sounds good thanks for the detailed description. I like the approach. This change can be easily cherry-picked into v2 once merged. |
Sounds good thanks for the detailed description. I like the approach. This change can be easily cherry-picked into v2 once merged. |
nywilken
pushed a commit
that referenced
this pull request
Mar 13, 2023
Remove `bomb.zip` test file to stop anti-virus noise
nywilken
added a commit
that referenced
this pull request
Mar 13, 2023
* Merge pull request #424 from hashicorp/fix-av-reports Remove `bomb.zip` test file to stop anti-virus noise * Update call to WriteFile --------- Co-authored-by: Kent 'picat' Gruber <kent@hashicorp.com>
8 tasks
lazyfrosch
added a commit
to lazyfrosch/terraform-provider-rancher2
that referenced
this pull request
May 11, 2023
This is a recommended fix to avoid security alerts downloading the current release, that contained a suspicious test ZIP file. see: - https://github.com/hashicorp/go-getter/releases/v1.7.1 - hashicorp/go-getter#424 - hashicorp/go-getter#419
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #419. The
bomb.zipfile was useful to verify the zip bomb protections worked properly, but is not required to verify our mitigations work. Including a real zip bomb lead to confusion and reports of anti-virus causing issues for users. Instead, a zip file is created inline with the test before verifying the decompression limit works.