fix(getter): race condition when SetClient is called #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-breaking change. This fixes an issue when Clients are created and called concurrently.
Clients called
SetClient
on each of theGetter
s. When no getters were provided, it modified the clients of the default getters defined in theGetters
map.Since the map was mutated from multiple goroutines, it creates a race condition 'concurrent map writes'. The issue is mitigated by creating a new copy of
Getters
usingDefaultGetters()
function for every new client created.SetClient
now modifies its own copy of theGetter
, not the defaultGetters
.To reproduce the issue:
go run -race .