Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] update s3, and gcs to use most recent v2 module version #489

Merged
merged 1 commit into from
May 20, 2024
Merged

[v2] update s3, and gcs to use most recent v2 module version #489

merged 1 commit into from
May 20, 2024

Conversation

nywilken
Copy link
Contributor

No description provided.

@nywilken nywilken force-pushed the deps/bump-submodules-v2.2.2 branch from a0822c6 to e92311b Compare May 20, 2024 18:00
JenGoldstrich
JenGoldstrich approved these changes May 20, 2024
View reviewed changes
Copy link

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think you need to run go mod tidy though based on the CI failures

@nywilken nywilken merged commit e51bb20 into v2 May 20, 2024
22 checks passed
@nywilken nywilken deleted the deps/bump-submodules-v2.2.2 branch May 20, 2024 18:03
@nywilken nywilken mentioned this pull request May 20, 2024
Merged
@nywilken nywilken mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JenGoldstrich JenGoldstrich JenGoldstrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nywilken @JenGoldstrich