Fix combination generator in CompoundMultiIndex #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Thanks for moving this forward! I wrote a benchmark and property test in #110. The property test found one panic when AllowMissing is true, which was fixed by a length check.
The benchmark shows 31 allocs for this test case, which seems high to me. I suspect we could reduce the allocations somehow, but probably not worth going down that path right now considering this was previous entirely broken.
Also fix a bug when the index is 0 length, found by the property test Also cleanup the existing test a little bit by using the '\x00' literal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72 and #106.
This is a continuation of #107. On top of the bug fix, I added a test to express the issue.
The bug is detailed in #72 and #106. The issue is that the traversal that is done to walk the structure doesn't preserve the path correctly so only a subset of the index would ever be generated.
Thanks to @WingGithub for the original fix in #107. We wanted to get this in without losing their contribution so I made sure to pull in their commit to my branch.