Skip to content

add Group.SetLimit(n int) #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add Group.SetLimit(n int) #94

wants to merge 2 commits into from

Conversation

@markus-wa
Copy link

@markus-wa markus-wa commented Feb 13, 2024

This allows us to control the max number of goroutines that can be ran concurrently

@markus-wa markus-wa requested review from a team, emilymianeil and sarahethompson February 13, 2024 17:22
@markus-wa
Copy link
Author

markus-wa commented Feb 13, 2024

note: golang.org/x/sync/errgroup already has this functionality - but unfortunately they only return the first error when more than one occurred - so I figured it made sense to add the SetLimit functionality here instead

ccampo133
ccampo133 reviewed May 22, 2024
View reviewed changes
@markus-wa @ccampo133
fix potential nil deref in Group.Go() defer
63bec96 
Co-authored-by: Chris Campo <ccampo133@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarahethompson sarahethompson Awaiting requested review from sarahethompson

@emilymianeil emilymianeil Awaiting requested review from emilymianeil

1 more reviewer

@ccampo133 ccampo133 ccampo133 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markus-wa @ccampo133