GRPCBroker: add DialWithOptions #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jmank88
force-pushed
the
dial-with-options
branch
from
7bb12ec to
0f4d515
Compare
jmank88
force-pushed
the
dial-with-options
branch
from
0f4d515 to
b3b9151
Compare
|
Rebased muxer conflicts. |
|
@tomhjp @VioletHynes Is someone available to consider this feature (or #251)? 🙏 |
|
Hey! This seems super reasonable. Thanks for raising this. I'll try and get somebody's eyes on this shortly. |
divyaac
approved these changes
Aug 29, 2024
This was referenced Aug 30, 2024
hanzei
pushed a commit
to hanzei/go-plugin
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating new clients and servers with a
type GRPCBroker,grpc.ServerOptions can be added when usingAccept(id uint32)andAcceptAndServe(id uint32, s func([]grpc.ServerOption) *grpc.Server), butgrpc.DialOptions cannot be added when usingDial(id uint32).This PR proposes adding a
DialWithOptions(id uint32, opts ...grpc.DialOption)method.Note:
Dialcould be updated in place without affecting typical uses, but the signature change would still be breaking.(this is the approach proposed in #251)