Remove go-testing-interface from go-plugin #312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a little unclear why the go.sum is like that, I was having issues with
go mod tidy
and it told me to dogo mod tidy -go=1.16 && go mod tidy -go=1.17
, and I did, and nowgo mod tidy
seems to work.Anyway, this removes go-testing-interface from this project. The behaviour should be exactly the same in this project with the Go stdlib version.
For more discussion as to why that's a good thing, see: https://github.com/hashicorp/vault-enterprise/pull/6101 and https://go.hashi.co/rfc/vlt-323. I noticed it was here by it still being an indirect dependency for Vault and I was already in the removal headspace, so I thought why not fix it here too :)
When we get the next version of this in Vault, it will also remove it as an indirect dependency.