Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go-testing-interface from go-plugin #312

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

VioletHynes
Copy link
Contributor

@VioletHynes VioletHynes commented Jul 4, 2024

I'm a little unclear why the go.sum is like that, I was having issues with go mod tidy and it told me to do go mod tidy -go=1.16 && go mod tidy -go=1.17, and I did, and now go mod tidy seems to work.

Anyway, this removes go-testing-interface from this project. The behaviour should be exactly the same in this project with the Go stdlib version.

For more discussion as to why that's a good thing, see: https://github.com/hashicorp/vault-enterprise/pull/6101 and https://go.hashi.co/rfc/vlt-323. I noticed it was here by it still being an indirect dependency for Vault and I was already in the removal headspace, so I thought why not fix it here too :)

When we get the next version of this in Vault, it will also remove it as an indirect dependency.

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The tests all pass except for TestGRPC_Reflection but that seems to be failing on main as well.

@VioletHynes VioletHynes merged commit 0e45961 into main Jul 9, 2024
1 check passed
hanzei pushed a commit to hanzei/go-plugin that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants