Invalid JSON on stderr crashes Client #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that the Client logging can handle non key-value json output from the client.
The isJSON checked if the output was valid json of any type, but the
logger only unmarshaled into `map[string]interface{}`. If the line
didn't umarshal correctly, the error was only logged, but the actual
line was lost and the loop continued into a nil pointer dereference.
Always log the raw line if it can't unmarshal into a map.
calvn
approved these changes
Aug 16, 2017
mitchellh
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isJSON checked if the output was valid json of any type, but the
logger only unmarshaled into
map[string]interface{}. If the linedidn't umarshal correctly, the error was only logged, but the actual
line was lost and the loop continued into a nil pointer dereference.
Always log the raw line if it can't unmarshal into a map.
Fixes hashicorp/terraform#15822