Added LeveledFormatLogger (Printf-like logger)

[juanfresia]

Hi everyone!

I was having a hard time trying to use logrus logger interface to work with go-retryablehttp, having no other choice that to implement a wrapper to align the two interfaces. Also, I was not the first to attempt stumble upon this (see #93).

Changes

So I tried to add support in go-retryablehtp for interfaces like logrus logger, which uses the Printf family of functions to output formatted logs (there is one for each level: Infof, Debugf, etc).

The change is generic (it is not tied to logrus), and it only adds a new logger interface called LeveledFormatLogger, which is similar to LeveledLogger but uses the Printf style for formatting and adding arguments to the logs.

A wrapper was provided to use the new interface as a simple Logger (hookFormatLogger), and all log lines have now an alternative with LeveledFormatLogger.

Example

Here is an example of the output with the changes:

DEBUG GET http://localhost:8081/test: performing request 
ERROR GET http://localhost:8081/test: request failed: Get "http://localhost:8081/test": dial tcp [::1]:8081: connect: connection refused 
DEBUG GET http://localhost:8081/test: retrying request in 1s (10 left) 
ERROR GET http://localhost:8081/test: request failed: Get "http://localhost:8081/test": dial tcp [::1]:8081: connect: connection refused 
DEBUG GET http://localhost:8081/test: retrying request in 2s (9 left) 
ERROR GET http://localhost:8081/test: request failed: Get "http://localhost:8081/test": dial tcp [::1]:8081: connect: connection refused 
DEBUG GET http://localhost:8081/test: retrying request in 4s (8 left) 

As opposed to the same output while using logrus as a default Logger

INFO [DEBUG] GET http://localhost:8081/test       
INFO [ERR] GET http://localhost:8081/test request failed: Get "http://localhost:8081/test": dial tcp [::1]:8081: connect: connection refused 
INFO [DEBUG] GET http://localhost:8081/test: retrying in 1s (10 left) 
INFO [ERR] GET http://localhost:8081/test request failed: Get "http://localhost:8081/test": dial tcp [::1]:8081: connect: connection refused 
INFO [DEBUG] GET http://localhost:8081/test: retrying in 2s (9 left) 
INFO [ERR] GET http://localhost:8081/test request failed: Get "http://localhost:8081/test": dial tcp [::1]:8081: connect: connection refused 
INFO [DEBUG] GET http://localhost:8081/test: retrying in 4s (8 left) 

This is what I'm currently using, and given it is a small change I thought it could be interesting to bring it upstream. Let me know what you think!

Signed-off-by: Juan Manuel Fresia juanmanuelfresia@gmail.com

[hashicorp-cla]

All committers have signed the CLA.

[jefferai]

LGTM but needs CLA signed and would like @evanphx to take a look as well since he does more maintaining here.

[juanfresia]

Thanks @jefferai, I've signed the CLA, and rebased the changes to master.

[alexandrevilain]

Hi :)

Any news on this Pull Request merge ETA ?

[juanfresia]

Maybe @evanphx could take a look?

[evanphx]

I suppose this is fine, though I worry about having this massive footprint of different logging interfaces embedded in a simple package.

[greut]

w.r.t logrus we did that to turn it into a LeveledLogger https://play.golang.org/p/yQ1io2eYJWK

many libraries have logr compatible interface, which would be yet another interface.

[martinsirbe]

Hi, any plans of getting this merged anytime soon? :)

[sylr]

I'm also interested in this.

[StarpTech]

@ryanuber Any chance to merge and publish it?

[achuchev]

Any news on this?

[crashiura]

Hi @ryanuber could take a look?

[akashsinghal]

Any update on this? Would be very helpful

[VaismanLior]

Hey, would be helpful to have this support.
Any plans to merge this PR?

[thapabishwa]

cc @ryanuber any eta on this?

[kedare]

Same I am also interested, so far we disable completely the logging on this lib as it's unuseable.

[jwlv]

This looks like a pretty simple change that would help a lot of people. Any chance of it getting merged?

[greut]

@jwlv @kedare etc. did you try the little adapter posted just above? #101 (comment)

[jwlv]

@jwlv @kedare etc. did you try the little adapter posted just above? #101 (comment)

@greut thanks for the pointer. It worked great!

[kedare]

Unfortunately I don't work with go anymore :(

[alexrojco]

I am really interested in having this added!

[syzyfus]

Would be helpful if this was eventually merged :)