Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix body nil checking in NewRequest #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix body nil checking in NewRequest #120

wants to merge 1 commit into from

Commits on Jan 28, 2021

  1. Fix body nil checking in NewRequest 

    NewRequest accepts interface{} as body argument
but doesn't check it on nil properly. It should
check that not only variable is nil, but also pointer
value is nil. Otherwise it constructs different
Request objects for the same parameters. Tests are
added.
    Volodymyr Dorokhov committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    da2cc38 View commit details
    Browse the repository at this point in the history