Add roleprovider for role assumption by ec2 instance #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If WebIdentityTokenFile is empty, try to assume the role using pre-existing creds https://github.com/aws/aws-sdk-go/blob/main/aws/credentials/stscreds/assume_role_provider.go#L17-L24
|
|
|
As I mentioned on Discuss, we'll be making a cross-team effort to get this reviewed and solidified for inclusion. I wanted to comment here as well for accountability and visibility as well. :) |
|
Should resolve hashicorp/terraform-provider-vault#1808 |
|
closed by #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How it is today
The AWS SDK supports role assumption without a web token but stdlib doesn't currently use it https://github.com/aws/aws-sdk-go/blob/main/aws/credentials/stscreds/assume_role_provider.go
What this PR changes
If
WebIdentityTokenFileis empty, try to assume the role using pre-existing creds as documented in the provider aboveComments
This PR was created to identify a solution for hashicorp/terraform-provider-boundary#62
Please do not report that you don't like the naming, the comments, etc. This is me pointing out the problem and asking you to implement this however you see fit. Please take this PR and implement it according to your own guidelines.