fix: archive extraction header.Linkname and old dependencies #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduzgun-security
changed the title
dduzgun-security
requested changes
Jan 31, 2025
slug.go
Outdated
| @@ -552,6 +568,17 @@ func (p *Packer) validSymlink(root, path, target string) (bool, error) { | |||
| } | |||
| } | |||
|
|
|||
| func TargetWithinRoot(root string, target string) (bool, error) { | |||
There was a problem hiding this comment.
Should we move this to /internal/escapingfs/escapes.go? I'm sure this would be useful for future validations outside of the slug.go file too
There was a problem hiding this comment.
Do we need to create a new file in the said location ?
/internal/escapingfs/escapes.go -- cannot find any existing file or filepath mentioned.
There was a problem hiding this comment.
Made the changes. Created a new file and a test file.
| @@ -539,8 +548,15 @@ func (p *Packer) validSymlink(root, path, target string) (bool, error) { | |||
| if !strings.HasSuffix(prefix, "/") { | |||
There was a problem hiding this comment.
String manipulation here after a clean may cause some issues that we faced before that was resolved by d8b1ee7. The filepath.Join function should already handle missing "/". Some tests would be helpful on here for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the CVEs in below tickets: