Skip to content

Commit

Permalink
gate darwin-only tests properly
Browse files Browse the repository at this point in the history
  • Loading branch information
rboyer committed Jan 3, 2019
1 parent 5118179 commit 0af07ac
Showing 1 changed file with 17 additions and 5 deletions.
22 changes: 17 additions & 5 deletions ifaddrs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"fmt"
"net"
"reflect"
"runtime"
"testing"

sockaddr "github.com/hashicorp/go-sockaddr"
Expand Down Expand Up @@ -1656,11 +1657,12 @@ func TestLimitOffset(t *testing.T) {

func TestSortIfBy(t *testing.T) {
tests := []struct {
name string
sortStr string
in sockaddr.IfAddrs
out sockaddr.IfAddrs
fail bool
name string
sortStr string
in sockaddr.IfAddrs
out sockaddr.IfAddrs
fail bool
skipWhen func() bool
}{
{
name: "sort address",
Expand Down Expand Up @@ -1729,6 +1731,9 @@ func TestSortIfBy(t *testing.T) {
// en0 has the default route.
name: "sort +default",
sortStr: "+default",
skipWhen: func() bool {
return runtime.GOOS != "darwin"
},
in: sockaddr.IfAddrs{
sockaddr.IfAddr{
SockAddr: sockaddr.MustIPv4Addr("1.2.3.4"),
Expand All @@ -1753,6 +1758,9 @@ func TestSortIfBy(t *testing.T) {
{
name: "sort -default",
sortStr: "-default",
skipWhen: func() bool {
return runtime.GOOS != "darwin"
},
in: sockaddr.IfAddrs{
sockaddr.IfAddr{
SockAddr: sockaddr.MustIPv4Addr("1.2.3.3"),
Expand Down Expand Up @@ -1965,6 +1973,10 @@ func TestSortIfBy(t *testing.T) {
if test.name == "" {
t.Fatalf("test %d needs a name", i)
}
if test.skipWhen != nil && test.skipWhen() {
t.SkipNow()
continue
}

t.Run(test.name, func(t *testing.T) {
sorted, err := sockaddr.SortIfBy(test.sortStr, test.in)
Expand Down

0 comments on commit 0af07ac

Please sign in to comment.