Add plural helpers #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @slackpad . It'd be nice if these PRs can get merged so we can also PR support into |
|
Sorry I just got back into town but I'll try to take a look at these asap.
…On May 22, 2017 4:44 PM, "Sean Chittenden" ***@***.***> wrote:
Ping @slackpad <https://github.com/slackpad> . It'd be nice if these PRs
can get merged so we can also PR support into gomplate (see
hairyhenderson/gomplate#145
<hairyhenderson/gomplate#145>).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AApG5TAtelNPcl2y_76d6hNXiBQsDNYAks5r8h3KgaJpZM4Nf60o>
.
|
|
No worries, I just wanted to bump the issue since I figured you were buried after traveling. |
|
@sean- want to rebase this one and we will get it in? The other changes ahead of this have been merged. |
…ctions. Returns a space-delimited list of respective IP addresses.
|
@slackpad Done. Thank you! |
sean-
added a commit
to sean-/go-sockaddr
that referenced
this pull request
May 23, 2017
* Adds plural IP helpers (e.g. `GetPrivateIPs`, `GetPublicIPs`) hashicorp#11 * Adds subnet math hashicorp#8 * Fixes helper functions for dual-homed hosts hashicorp#10)
sean-
added a commit
to sean-/go-sockaddr
that referenced
this pull request
May 23, 2017
* Adds plural IP helpers (e.g. `GetPrivateIPs`, `GetPublicIPs`) hashicorp#11 * Adds subnet math hashicorp#8 * Fixes helper functions for dual-homed hosts hashicorp#10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful in hashicorp/consul#3037 and hashicorp/consul#2217