Add a private selector to the include and exclude filters.
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests (omitting |
kwilczynski
force-pushed
the
f-add-private-selector
branch
from
a683306 to
06f5d0d
Compare
This commit adds support for a `private` selector to the `include` and `exclude`
filters allowing to filter out private IP addresses accordingly leveraging RFC
6890 to identify a private IP addresses. This new functionality would be the
`eval` equivalent of (using include as an example):
````
$ sockaddr eval -r '{{ GetAllInterfaces | include "rfc" "6890" }}'
````
Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
kwilczynski
force-pushed
the
f-add-private-selector
branch
from
06f5d0d to
bd55e00
Compare
|
After speaking with @sean- about this we decided that this is not an appropriate addition. As convenience as it is, it adds a special snowflake of a use-case to make it work, and therefore we do not want to support it (more special code carries out the burden of having to special a special case of some sort, and I fully agree with this). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for a
privateselector to theincludeandexcludefilters allowing to filter out private IP addresses accordingly leveraging RFC
6890 to identify a private IP addresses. This new functionality would be the
evalequivalent of (using include as an example):Signed-off-by: Krzysztof Wilczynski kw@linux.com