Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I avoided adding similar check to
Compare
as the meaning of any integer value there could be misleading, but I believe that the check inEqual
is useful e.g. in test cases wherenil
can appear and equality is checked, either directly, or via library such as https://github.com/google/go-cmp which callsEqual
on any struct via reflection.Such comparisons panic without this patch and therefore don't provide useful output from tests.