Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expirable LRU: fix so that Get/Peek cannot return an ok and empty value #156

Merged
merged 2 commits into from
Sep 14, 2023
Merged

expirable LRU: fix so that Get/Peek cannot return an ok and empty value #156

merged 2 commits into from
Sep 14, 2023

Conversation

irenarindos
Copy link
Collaborator

Fixes #150 where if an item is expired and the expiration reaper hasn't run yet, we'd return true and an empty value

@irenarindos irenarindos requested a review from mgaffney August 31, 2023 15:31
@irenarindos irenarindos merged commit d46c1d9 into master Sep 14, 2023
@Ivlyth
Copy link

Ivlyth commented Sep 22, 2023

When will the version containing this fix be released?

@irenarindos
Copy link
Collaborator Author

@Ivlyth This has now been released in https://github.com/hashicorp/golang-lru/releases/tag/v2.0.7

@Ivlyth
Copy link

Ivlyth commented Oct 7, 2023

@Ivlyth This has now been released in https://github.com/hashicorp/golang-lru/releases/tag/v2.0.7

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paskal paskal paskal approved these changes

@mgaffney mgaffney Awaiting requested review from mgaffney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expirable LRU can return nil value with ok = true
3 participants
@irenarindos @Ivlyth @paskal