Implement for_each and each.* completion, hover info, and semantic tokens #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
force-pushed
the
foreach_each_extensions
branch
from
c2d5a9d
to
ef1e7ad
Compare
jpogran
commented
Oct 25, 2022
radeksimko
reviewed
Oct 26, 2022
There was a problem hiding this comment.
This is looking pretty good. Aside from my in-line comments we're also missing hover tests.
On the note of testing - in general, when I'm unsure what needs testing, I'd use the coverage report which is built into Go:
go test -coverprofile=coverage.out ./...
go tool cover -html=coverage.out
That's not to say I'd expect you to cover 100%, but I think it can provide a good guidance.
radeksimko
approved these changes
Oct 28, 2022
jpogran
force-pushed
the
foreach_each_extensions
branch
from
e8c152a
to
3666c83
Compare
This provides completion hints inside blocks for `for_each` and `each.*` references within `resource`, `data` and `module` blocks anywhere the `for_each` meta-argument is supported. It detects if `for_each` is used already and does not suggest duplicates and detects when it is necessary to provide `each.*` completions. This does not complete the values for `each.key` and `each.value`, e.g. `each.value.something`. This also provides hover support for `for_each` and `each.*` references using the documentation as source. This also provides semantic token support for `for_each` and `each.*` references. Closes hashicorp/terraform-ls#861
jpogran
force-pushed
the
foreach_each_extensions
branch
from
3666c83
to
809103e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides completion hints inside blocks for
for_eachandeach.*references withinresource,dataandmoduleblocks anywhere thefor_eachmeta-argument is supported. It detects iffor_eachis used already and does not suggest duplicates and detects when it is necessary to provideeach.*completions. This does not complete the values foreach.keyandeach.value, e.g.each.value.something.This also provides hover support for
for_eachandeach.*references using the documentation as source.This also provides semantic token support for
for_eachandeach.*references.Closes hashicorp/terraform-ls#861