decoder/schema: Pass PrefillRequiredFields around via context
#230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-ctx-prefill-req-fields
branch
from
b9b2586
to
02495a1
Compare
radeksimko
changed the title
PrefillRequiredFields around via contextPrefillRequiredFields around via context
dbanck
approved these changes
Mar 14, 2023
| @@ -164,7 +165,8 @@ func requiredFieldsSnippet(bodySchema *schema.BodySchema, placeholder int, inden | |||
|
|
|||
| var snippet string | |||
| if attr.Constraint != nil { | |||
| snippet = attr.Constraint.EmptyCompletionData(placeholder, indentCount).Snippet | |||
| ctx := schema.WithPrefillRequiredFields(context.Background(), true) | |||
There was a problem hiding this comment.
Added a comment. We could still refactor related functions later and plumb the context all the way through, but I feel it's better not to do it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered while implementing #203 that
schema.Object.EmptyCompletionData()always pre-fills all attributes, which is undesirable.PrefillRequiredFields, and this should be reflected in objects as wellI also did a little bit of refactoring to (hopefully) make the code more readable, in spite of the additional complexity.
All commits are also part of #203 but I decoupled them here to make it easier to review.
Side note
This will also enable us to later customise the existing literal type/value pre-filling like
attr = "value"orattr = false- maybe put it behind a similar feature toggle or do any A/B testing etc.I wanted to attach some GIFs but this is unfortunately hard to demo without the remaining work in #203