Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nil expr panics #376

Merged
merged 6 commits into from
Feb 29, 2024
Merged

fix: nil expr panics #376

merged 6 commits into from
Feb 29, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Feb 20, 2024 •
edited
Loading

When Terraform provider defined functions are incomplete (e.g. when completing provider::), hcl returns a nil Expr which causes all kinds of panics.

This PR handles such nil values for different things.

@ansgarm ansgarm changed the title fix nil expr panics fix: nil expr panics Feb 20, 2024
@ansgarm ansgarm mentioned this pull request Feb 21, 2024
Closed
11 tasks
ansgarm
ansgarm commented Feb 22, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@ansgarm ansgarm marked this pull request as ready for review February 22, 2024 10:56
@ansgarm ansgarm requested a review from a team as a code owner February 22, 2024 10:56
@ansgarm ansgarm mentioned this pull request Feb 23, 2024
Closed
dbanck
dbanck requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor suggestion to suppress completion

decoder/candidates_test.go Outdated Show resolved Hide resolved
decoder/candidates.go Show resolved Hide resolved
@ansgarm ansgarm requested a review from dbanck February 28, 2024 12:43
@dbanck dbanck changed the base branch from main to pre-release February 29, 2024 10:17
@dbanck dbanck merged commit ff422a4 into pre-release Feb 29, 2024
1 check passed
@dbanck dbanck deleted the fix-nil-expr-panics branch February 29, 2024 10:33
@ansgarm ansgarm mentioned this pull request Mar 5, 2024
Closed
@ansgarm ansgarm mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansgarm @dbanck