BodySchema: Introduce (dedicated) HoverURL #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For provider linking we initially wanted (and still want) links both in hover and explicitly exposed via
LinksInFileand correspondingtextDocument/documentLinkLSP method.However there are cases where direct linking would be too distracting and inappropriate, given how it's implemented in VS Code and probably elsewhere. In other words we don't want so much code to be underlined all the time.
Providing a link in a more subtle way in hover data is still valuable, so this field aims to strike the balance.