gohcl/decode.go: fix decoding value slices #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if user tries to decode such scenario, it results in "slice index out of range". Fixes regression introduced in 42351b1. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
|
Ping @apparentlymart :) |
1 similar comment
|
Ping @apparentlymart :) |
|
ping @alisdair |
alisdair
approved these changes
Nov 19, 2020
invidian
added a commit
to kinvolk/lokomotive
that referenced
this pull request
Dec 1, 2020
To include hashicorp/hcl#335. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
added a commit
to kinvolk/lokomotive
that referenced
this pull request
Dec 2, 2020
To include hashicorp/hcl#335. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
added a commit
to kinvolk/lokomotive
that referenced
this pull request
Dec 3, 2020
To include hashicorp/hcl#335. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if user tries to decode such scenario, it results in
"slice index out of range".
Fixes regression introduced in 42351b1.
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io