Nomad v2.17.0+tweaks #620
Draft
Nomad v2.17.0+tweaks #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrycub
commented
Nov 16, 2023
Comment on lines
+104
to
+106
| if fn, ok := d.bodyConvertors[val.Type()]; ok { | ||
| return fn(body, ctx, val.Addr().Interface()) | ||
| } |
There was a problem hiding this comment.
Nomad allows for constraint blocks where certain operators can be expressed as LHS constants. For example, the canonical distinct_hosts constraint is written as follows:
constraint {
operator = "distinct_hosts"
value = "true"
}However, Nomad supports an alternative representation of this same constraint.
constraint {
distinct_hosts = true
}Before re-adding this code, the shortened form would produce the following error.
Unsupported argument; An argument named "distinct_hosts" is not expected here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch applies all of the Nomad tweaks to the v2.17.0 release. This will enable Nomad and Nomad-pack to leverage to the Extra field on Diagnostics.