Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests on macOS #660

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Run unit tests on macOS #660

merged 3 commits into from
Feb 26, 2024

Conversation

radeksimko
Copy link
Member

Run tests on macOS

Previously we did not run unit tests on macOS. I don't know all the history but I will assume that was because the macOS runners were not available early on, or were otherwise difficult to use.

It seems relatively unlikely that there would be macOS-specific bugs we could discover that aren't more broadly Unix bugs (i.e. bugs that would be surfaced through Linux tests).

Regardless, the reality is that the products downstream of HCL, such as Terraform, do have macOS user base and we regularly run tests on macOS, so it would seem reasonable to also do it here.

Read Go version from go.mod

While strictly speaking the version in go.mod is compatibility constraint, we always seem to test against that version, i.e. there is no difference in practice between the version we claim compatibility with and the version we test against.

We could start testing additionally against newer Go versions too but I was trying to keep this PR small in scope, to keep the review easier.

@radeksimko radeksimko requested a review from a team February 16, 2024 14:33
@radeksimko radeksimko merged commit bd58136 into main Feb 26, 2024
17 checks passed
@radeksimko radeksimko deleted the ci-test-on-macos branch February 26, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants