Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update github.com/mitchellh/go-wordwrap to v1.0.1 #734

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

thaJeztah
Copy link
Contributor

@thaJeztah thaJeztah commented Mar 5, 2025

Update the dependency to use a tagged release; changes since the version used;

  • Add go.mod
  • Wrap multibyte characters properly
  • Do not break on non-breaking space

full diff: mitchellh/go-wordwrap@ad45545...v1.0.1

@thaJeztah thaJeztah requested review from a team as code owners March 5, 2025 21:30
@thaJeztah thaJeztah force-pushed the wordwrap_tagged_release branch from e711ac6 to 77de657 Compare March 5, 2025 21:32
@thaJeztah
Copy link
Contributor Author

/cc @apparentlymart @jbardin

Update the dependency to use a tagged release; changes since the
version used;

- Add go.mod
- Wrap multibyte characters properly
- Do not break on non-breaking space

full diff: mitchellh/go-wordwrap@ad45545...v1.0.1

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the wordwrap_tagged_release branch from 77de657 to f1a848a Compare March 25, 2025 17:50
@thaJeztah
Copy link
Contributor Author

/cc @KaushikiAnand ptal 🤗

Copy link
Contributor

@mohanmanikanta2299 mohanmanikanta2299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the library is only used to wrap diagnostic wording, so this should have minimal risk in spite of the major version update.

Thanks for the PR.

@radeksimko radeksimko merged commit b4e1e14 into hashicorp:main Apr 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants