Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace go get with go install #123

Merged
merged 6 commits into from
Sep 9, 2022
Merged

Replace go get with go install #123

merged 6 commits into from
Sep 9, 2022

Conversation

itsjaspermilan
Copy link
Contributor

@itsjaspermilan itsjaspermilan commented Sep 9, 2022 •
edited
Loading

🛠️ Description

Since we updated to go 1.18 we shouldn't be using go get to install packages anymore. Instead, we can use go install to correctly install packages that aren't part of our go.mod

🔗 External Links

  • Dev blog that explains the change: link

🚢 Release Note

Release note for CHANGELOG:

Replace `go get` with `go install` since we're using go 1.18

👍 Definition of Done

  • SDK added
  • SDK updated
  • Tests added?
  • Docs updated?

@itsjaspermilan itsjaspermilan marked this pull request as ready for review September 9, 2022 15:55
@itsjaspermilan itsjaspermilan requested a review from a team September 9, 2022 15:55
@itsjaspermilan itsjaspermilan changed the title Test update golang ci to latest Replace go get with go install Sep 9, 2022
@itsjaspermilan itsjaspermilan merged commit 5082119 into main Sep 9, 2022
@itsjaspermilan itsjaspermilan deleted the test-update-golang-ci-to-latest branch September 9, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcmdarroch bcmdarroch bcmdarroch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsjaspermilan @bcmdarroch