HCE-556 Implement Auto Releaser #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JolisaBrownHashiCorp
approved these changes
Oct 24, 2022
| run: | | ||
| go install github.com/hashicorp/go-changelog/cmd/changelog-build@6ec9be372335f39c5df27e232c3669db7f5183a5 | ||
| go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.49.0 | ||
|
|
There was a problem hiding this comment.
Nice! Did version 1.49.0 fix the linting concerns you mentioned?
| ~~~ | ||
|
|
||
| Where `TYPE` is the type of release note entry this is. This is one of either: `breaking-change`, `security`, `feature`, `improvement`, `deprecation`, `bug`. | ||
|
|
There was a problem hiding this comment.
✨ I love the thoroughness of explanation here on release-note types. The only potential knitpick I could suggest is maybe updating the default PR template to remind creating a changelog entry addition and listing as well the TYPE for releases. LGTM! 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Description
This PR aims to set up auto release functionality for the HCP SDK Go.
What Changed
go-changelogpackage