Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated consul service with instructions #24

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Conversation

hanshasselberg
Copy link
Member

@hanshasselberg hanshasselberg commented Jun 14, 2021

🛠️ Description

Updated Consul Service to add new field primary and new tier plus. Followed https://hashicorp.atlassian.net/wiki/spaces/CLOUD/pages/1523744830/Go+SDK. Needs https://github.com/hashicorp/cloud-api/pull/45.

This is what I did:

  1. git clone git@github.com:hashicorp/cloud-api.git
  2. git clone git@github.com:hashicorp/hcp-sdk-go.git
  3. cd cloud-api
  4. cp ../cloud-consul-service/proto-public/20210204/swagger/hcp.swagger.json specs/cloud-consul-service/preview/2021-02-04/consul.swagger.json
  5. GO111MODULE=off go get ./...
  6. GO111MODULE=off make

Somehow this resulted in a LOT of changes.

🔗 External Links

🚢 Release Note

Release note for CHANGELOG:

...

👍 Definition of Done

  • SDK added
  • SDK updated
  • Tests added?
  • Docs updated?

@hanshasselberg hanshasselberg requested a review from a team June 14, 2021 09:31
@hanshasselberg hanshasselberg changed the title updated consul service Updated consul service with instructions Jun 14, 2021
@hanshasselberg
Copy link
Member Author

🤔 Not sure why this test is failing...

@bcmdarroch
Copy link
Contributor

Hm that is an odd failure, I'll investigate.

@hanshasselberg
Copy link
Member Author

Thanks @bcmdarroch!
Providing some context as to why I think this error is strange: it errors for an older API version that I didn't touch and complains about a field that should be readonly. Even more strange is that this field is marked as readonly in the corresponding swagger file.

I just copied over the most recent swagger file from consul-service for the old API version and ran make in cloud-api. But that didn't change anything in hcp-sdk-go.

hanshasselberg and others added 2 commits June 15, 2021 11:33
will regen whole SDK on latest go-swagger version in a follow-up
Copy link
Contributor

@bcmdarroch bcmdarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed this up by regenerating on v0.25.0 of go-swagger, so now this only touches the relevant Consul files. To keep these changes separate and distinct, I'll follow up with a regen of the whole SDK using the latest v0.27.0.

For folks watching at home, the original CI error was due to the go-openapi/validate package being out of date, so there's some bonus dependency bumps in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants