Allow one or both conditional operands to be unknown #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently these fail, due to a regression that wasn't caught due to us not having these tests to begin with. They will be fixed in a subsequent commit.
In #52 we relaxed the rule that any unknown value would immediately cause an early exit, which in turn requires the type checker for each node to specifically deal with unknown values. However, we missed dealing with the check that both types match in a conditional, causing a conditional to fail if either side of it is unknown. This causes errors in Terraform, as described in hashicorp/terraform#14399.
apparentlymart
changed the title
mitchellh
approved these changes
May 12, 2017
apparentlymart
added a commit
to hashicorp/terraform
that referenced
this pull request
May 12, 2017
hashicorp/hil#53 addresses a regression with type checking of unknown values in the HIL conditional operator. This fixes #14399.
apparentlymart
added a commit
to hashicorp/terraform
that referenced
this pull request
May 12, 2017
hashicorp/hil#53 addresses a regression with type checking of unknown values in the HIL conditional operator. This fixes #14399.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #52 we relaxed the rule that any unknown value would immediately cause an early exit, which in turn requires the type checker for each node to specifically deal with unknown values.
However, we missed dealing with the check that both types match in a conditional, causing a conditional to fail if either side of it is unknown.
This causes errors in Terraform, as described in hashicorp/terraform#14399.