Use non root user #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, you got to this before me.. I'll delete my 2nd PR and we can keep this one! |
Closed
DanStough
force-pushed
the
use_non_root_user
branch
from
7727885 to
cf5d190
Compare
|
@kschoche made similar changes to the |
|
Article I used for scratch image as reference: https://medium.com/@lizrice/non-privileged-containers-based-on-the-scratch-image-a80105d6d341 |
|
@DanStough Cool, that is a good idea to get the scratch image in the same state! I haven't tested it but just wanted to confirm that it doesn't break things (maybe run the consul-k8s acceptance tests against this image?) |
DanStough
force-pushed
the
use_non_root_user
branch
from
cf5d190 to
9e66118
Compare
|
Ran against some basic connect service tests. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-opening #9 from @kschoche