Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build test #130

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Build test #130

merged 3 commits into from
Feb 24, 2025

Conversation

KaushikiAnand
Copy link
Contributor

  • Unit test coverage added to the ci.yml workflow.
  • .go-version file added

@KaushikiAnand KaushikiAnand requested review from a team as code owners February 21, 2025 13:20
tauhid621
tauhid621 reviewed Feb 24, 2025
View reviewed changes
Copy link

@tauhid621 tauhid621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great.
There is one comment regarding the go version to be used in go-version file based on go mod file. Left few other minor comments as well.

tauhid621
tauhid621 approved these changes Feb 24, 2025
View reviewed changes
Copy link

@tauhid621 tauhid621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the suggested changes.

@KaushikiAnand KaushikiAnand merged commit 7843775 into main Feb 24, 2025
2 checks passed
@KaushikiAnand KaushikiAnand deleted the build-test branch February 24, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absolutelightning absolutelightning absolutelightning left review comments

@tauhid621 tauhid621 tauhid621 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaushikiAnand @tauhid621 @absolutelightning