Fix udp writes not causing nodes to become suspect #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failedRemote only checks for TCP failures but probeNode uses UDP meaning that if we get a "network is unreachable" during a UDP write the node is never marked as suspect.
|
|
|
Fixes hashicorp/serf#627 |
kyhavlov
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Hi @Austinpayne, this looks great, thanks for the PR and the clean reproduction setup!
|
Thanks @kyhavlov. Should I open a PR to bump the memberlist version in the serf repo as well? |
|
Awesome - I've made a local build of Can I help with tagging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failedRemote only checks for TCP failures but probeNode uses
UDP meaning that if we get a "network is unreachable" during
a UDP write the node is never marked as suspect.
This failure mode can be reproduced by bringing down an
interface in which case the node will show its neighbors
as alive while all other nodes will properly detect the
node as failed.
For reproduction steps see: https://gist.github.com/Austinpayne/defc5178bc2cc5c29ff5ada3dc4b1260
For verifying the fix see: https://gist.github.com/Austinpayne/151876ba8841be46484ce71664ced6bc