Purge left nodes along with dead ones (#253) #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanshasselberg
requested changes
Jan 7, 2022
dnephin
reviewed
Jan 7, 2022
There was a problem hiding this comment.
Thanks for the fix! One suggestion for the godoc.
Is there any way we can test this from within memberlist? If a full integration test makes it difficult to reproduce, maybe just a test of moveDeadNodes, to show that it moves nodes in both states? Edit: Oh, I missed that Hans already suggested a test for this, that sounds good!
Co-authored-by: Hans Hasselberg <hans@hashicorp.com>
Co-authored-by: Daniel Nephin <dnephin@gmail.com>
|
Added StateLeft to the moveDeadNodes test. Should be all set @i0rek |
kisunji
reviewed
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the state from infinitely expanding