-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit metrics for local memberlist size and remote memberlist size #276
Conversation
1784529
to
e3a4ff1
Compare
4d3dd8a
to
a6a4ca2
Compare
066c9e5
to
78cc9b5
Compare
78cc9b5
to
12b962d
Compare
ee0860e
to
ed85e1e
Compare
177a2cc
to
7ebe704
Compare
@@ -1042,6 +1074,9 @@ func (m *Memberlist) sendLocalState(conn net.Conn, join bool, streamLabel string | |||
} | |||
} | |||
|
|||
moreBytes := binary.BigEndian.Uint32(bufConn.Bytes()[1:5]) | |||
metrics.SetGaugeWithLabels([]string{"memberlist", "size", "local"}, float32(moreBytes), m.metricLabels) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestions for a better metric name? (also, see question below about removing the remote metric, which might make naming this easier.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the library versioning bumps are done these can be documented on the consul telemetry page on the website.
Changes proposed
"memberlist", "node", "instances"
Gauge and pass label so a gauge can be broken out by node state"memberlist", "size", "local"
Gauge that reports the size in bytes of the memberlist size before it is sent to another gossip recipient.![Screen Shot 2022-08-30 at 11 56 46 AM](https://user-images.githubusercontent.com/2481360/187511234-bbaab80a-f5a4-46b5-a907-7463006d801f.png)
- emit `"memberlist", "size", "remote"` Gauge that reports the size of incoming memberlists from other gossip senders - is this helpful? I feel like we would have to add a label for who is sending it?