-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Can't resolve 'react/jsx-runtime.js' #250
Conversation
4981384
to
913c7d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@BRKalow This still works locally for me but Vercel is now refusing to build, giving the opposite error Trying to figure this out and test different things on the Vercel side (maybe something with node v14?) but if you want to revert this for now that might be wise... very sorry about that and to anyone else having problems! :) Possibly related, if anyone has any ideas:
|
@jakejarvis No worries! I reverted for now and published another release so folks won't get breakage over the weekend. Feel free to open another PR if you do figure something out! 🙏 |
Looks like this is the answer to fix React 18 — |
Worthwhile to deploy a new major version that pins it at React >= 18? |
@switz that's the most logical solution I can think of too, unfortunately |
For anyone who ended up here like I did, looking for a fix - make sure you're pinning to version |
Reverting back to |
Thanks for the insight here, y'all! I'll try to come up with something which works for both v17 and v18 this week. |
Simply changes the import of
react/jsx-runtime.js
toreact/jsx-runtime
. This was causing errors when using Preact and React 18 — shouldn't affect anything else as far as I know! :)fixes #237