Fix: export jsx-dev-runtime in development mode
#323
Merged
+102
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From `@mdx-js/mdx` version 2.2.0 onwards, the compiled source uses `jdxDEV` from `react/jsx-dev-runtime` in development mode instead. This patch determines whether we should export `jsx-dev-runtime` by checking `process.env.NODE_ENV`. This environment variable is always present in Next.js both in browser and server environment. `@mdx-js/*` are bumped to `^2.2.1` because this change is incompatible with version 2.1.5 or older. Signed-off-by: imtsuki <me@qjx.app>
|
|
|
I'll get this released tomorrow 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
@mdx-js/mdxversion 2.2.0 onwards, the compiled source usesjdxDEVfromreact/jsx-dev-runtimein development mode rather thanjdx-runtime. This patch determines whether we should exportjsx-dev-runtimeby checkingprocess.env.NODE_ENV. This environment variable should be always present in Next.js in both browser and server environment.@mdx-js/*are bumped to^2.2.1because this change is incompatible with version 2.1.5 or older.Fixes
TypeError: _jsxDEV is not a functionerror #307 (comment)