add scoped variables #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documentation was included on the wrong line.
|
|
|
This is incredible, thank you so much for the contribution @chewnoill! Going to take a moment to ensure I fully understand the changes that were made here, then will get this shipped out |
jescalan
approved these changes
Jul 8, 2020
| .then((jsx) => { | ||
| return `${renderer}\n${jsx}` | ||
| }) | ||
| return mdx(source, { ...options, skipExport: true }) |
There was a problem hiding this comment.
I hadn't dug up this skipExport option, this is a great find. I think we can also remove this transform safely now that it has been added!
This includes a refactor that removes the dependency on require-from-string.
chewnoill
force-pushed
the
chewy/scoped-variables
branch
from
a23bff5 to
75226ae
Compare
|
👏🏼 thank you again for the contribution! I'll have a release out for this shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋
This PR brings
next-mdx-remotemore in line with how the mdx-runtime works.see: https://github.com/mdx-js/mdx/blob/master/packages/runtime/src/index.js
Great work over here by the way, I like what you're doing