always return file policy for same id #625
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #519
I tried to reproduce the issue locally by setting up the autoscale and a local nomad agent running and connection each other. When restarting nomad the error message "failed to call the Nomad list policies" was shown as described in the issue and during debugging I noticed that the handler has no current policy anymore. I digged deeper and found the reason. The file source does not return a policy because the one that gets monitored is already registered in the policyMap and so no policy update is triggered which would set the currentPolicy at https://github.com/hashicorp/nomad-autoscaler/blob/main/policy/handler.go#L153
With this change the policy will be returned no matter what happened to the handler/source.