Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: add scale_in_protection configuration #807

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Dec 21, 2023

When scale_in_protection is enabled, the AWS target plugin skips instances that are protected from scale in operations[1].

Closes #650

[1] https://docs.aws.amazon.com/autoscaling/ec2/userguide/ec2-auto-scaling-instance-protection.html

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of minor inline suggestions or queries.

plugins/builtin/target/aws-asg/plugin/aws.go Outdated Show resolved Hide resolved
plugins/builtin/target/aws-asg/plugin/aws.go Outdated Show resolved Hide resolved
plugins/builtin/target/aws-asg/plugin/aws.go Outdated Show resolved Hide resolved
lgfa29 added 4 commits January 2, 2024 13:58
When `scale_in_protection` is enabled, the AWS target plugin skips
instances that are protected from scale in operations[1].

[1] https://docs.aws.amazon.com/autoscaling/ec2/userguide/ec2-auto-scaling-instance-protection.html
In some scenarios it may be useful to set a different value of
`scale_in_protection` per policy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-asg plugin: Respect scale-in protection
2 participants